From 7b0d1a92aa13931333213dc4d2971eabb41303e5 Mon Sep 17 00:00:00 2001 From: Vitaly Takmazov Date: Tue, 26 Sep 2017 07:34:39 +0300 Subject: tomcat-jdbc -> Hikari --- juick-server-jdbc/build.gradle | 2 +- .../src/main/java/com/juick/configuration/DataConfiguration.java | 7 ++++--- .../src/main/java/com/juick/configuration/SearchConfiguration.java | 5 +++-- src/test/java/com/juick/tests/ApiTests.java | 7 ++++--- 4 files changed, 12 insertions(+), 9 deletions(-) diff --git a/juick-server-jdbc/build.gradle b/juick-server-jdbc/build.gradle index 780048a7..e24caddf 100644 --- a/juick-server-jdbc/build.gradle +++ b/juick-server-jdbc/build.gradle @@ -31,7 +31,7 @@ dependencies { compile "org.springframework:spring-context:${rootProject.springFrameworkVersion}" compile "org.springframework:spring-jdbc:${rootProject.springFrameworkVersion}" - providedCompile 'org.apache.tomcat:tomcat-jdbc:8.5.20' + compile 'com.zaxxer:HikariCP:2.7.1' compile "com.googlecode.log4jdbc:log4jdbc:1.2" compile "javax.inject:javax.inject:1" diff --git a/juick-server-jdbc/src/main/java/com/juick/configuration/DataConfiguration.java b/juick-server-jdbc/src/main/java/com/juick/configuration/DataConfiguration.java index c4c77b40..a5baae2b 100644 --- a/juick-server-jdbc/src/main/java/com/juick/configuration/DataConfiguration.java +++ b/juick-server-jdbc/src/main/java/com/juick/configuration/DataConfiguration.java @@ -18,6 +18,7 @@ package com.juick.configuration; import com.juick.service.search.SearchService; +import com.zaxxer.hikari.HikariDataSource; import org.apache.commons.lang3.StringUtils; import org.springframework.context.annotation.*; import org.springframework.core.env.Environment; @@ -47,14 +48,14 @@ public class DataConfiguration implements TransactionManagementConfigurer { // But Datasource interface has no close() method @Bean public DataSource dataSource() { - org.apache.tomcat.jdbc.pool.DataSource dataSource = new org.apache.tomcat.jdbc.pool.DataSource(); + HikariDataSource dataSource = new HikariDataSource(); dataSource.setDriverClassName(env.getProperty("datasource_driver", "com.mysql.jdbc.Driver")); - dataSource.setUrl(env.getProperty("datasource_url")); + dataSource.setJdbcUrl(env.getProperty("datasource_url")); dataSource.setUsername(env.getProperty("datasource_user", StringUtils.EMPTY)); dataSource.setPassword(env.getProperty("datasource_password", StringUtils.EMPTY)); - dataSource.setValidationQuery("select 1"); + //dataSource.setValidationQuery("select 1"); return dataSource; } diff --git a/juick-server-jdbc/src/main/java/com/juick/configuration/SearchConfiguration.java b/juick-server-jdbc/src/main/java/com/juick/configuration/SearchConfiguration.java index 90dcefdc..1fc02039 100644 --- a/juick-server-jdbc/src/main/java/com/juick/configuration/SearchConfiguration.java +++ b/juick-server-jdbc/src/main/java/com/juick/configuration/SearchConfiguration.java @@ -19,6 +19,7 @@ package com.juick.configuration; import com.juick.service.search.SearchService; import com.juick.service.search.SphinxSearchServiceImpl; +import com.zaxxer.hikari.HikariDataSource; import org.apache.commons.lang3.StringUtils; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; @@ -42,10 +43,10 @@ public class SearchConfiguration { // But Datasource interface has no close() method @Bean public DataSource searchDataSource() { - org.apache.tomcat.jdbc.pool.DataSource dataSource = new org.apache.tomcat.jdbc.pool.DataSource(); + HikariDataSource dataSource = new HikariDataSource(); dataSource.setDriverClassName(env.getProperty("sphinx_driver", "com.mysql.jdbc.Driver")); - dataSource.setUrl(env.getProperty("sphinx_url")); + dataSource.setJdbcUrl(env.getProperty("sphinx_url")); dataSource.setUsername(env.getProperty("sphinx_user", StringUtils.EMPTY)); dataSource.setPassword(env.getProperty("sphinx_password", StringUtils.EMPTY)); diff --git a/src/test/java/com/juick/tests/ApiTests.java b/src/test/java/com/juick/tests/ApiTests.java index d97f84d2..403adfa6 100644 --- a/src/test/java/com/juick/tests/ApiTests.java +++ b/src/test/java/com/juick/tests/ApiTests.java @@ -32,6 +32,7 @@ import com.juick.service.TagService; import com.juick.service.UserService; import com.juick.service.search.SearchService; import com.juick.www.WebApp; +import com.zaxxer.hikari.HikariDataSource; import org.apache.commons.lang3.StringUtils; import org.junit.Before; import org.junit.Test; @@ -79,11 +80,11 @@ public class ApiTests { db.start(); db.createDB("juick"); db.source("schema.sql"); - org.apache.tomcat.jdbc.pool.DataSource dataSource = new org.apache.tomcat.jdbc.pool.DataSource(); + HikariDataSource dataSource = new HikariDataSource(); dataSource.setDriverClassName("com.mysql.jdbc.Driver"); - dataSource.setUrl("jdbc:mysql://localhost:33306/juick?autoReconnect=true&user=root"); + dataSource.setJdbcUrl("jdbc:mysql://localhost:33306/juick?autoReconnect=true&user=root"); - dataSource.setValidationQuery("select 1"); + // dataSource.setValidationQuery("select 1"); return dataSource; } catch (ManagedProcessException e) { -- cgit v1.2.3