juick-www: refactor social logins

1 files changed, 6 insertions, 7 deletions

diff --git a/juick-www/src/main/java/com/juick/www/controllers/FacebookLogin.java b/juick-www/src/main/java/com/juick/www/controllers/FacebookLogin.java
index 0067dbc6..e83bab92 100644
--- a/juick-www/src/main/java/com/juick/www/controllers/FacebookLogin.java
+++ b/juick-www/src/main/java/com/juick/www/controllers/FacebookLogin.java
@@ -33,7 +33,7 @@ import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.math.NumberUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.core.env.Environment;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.CookieValue;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -56,8 +56,10 @@ public class FacebookLogin {
 
     private static final Logger logger = LoggerFactory.getLogger(FacebookLogin.class);
 
-    private final String FACEBOOK_APPID;
-    private final String FACEBOOK_SECRET;
+    @Value("${facebook_appid}")
+    private String FACEBOOK_APPID;
+    @Value("${facebook_secret}")
+    private String FACEBOOK_SECRET;
     private final String FACEBOOK_REDIRECT = "http://juick.com/_fblogin";
     @Inject
     private ObjectMapper jsonMapper;
@@ -68,10 +70,7 @@ public class FacebookLogin {
     @Inject
     UserService userService;
 
-    @Inject
-    public FacebookLogin(Environment env) {
-        FACEBOOK_APPID = env.getProperty("facebook_appid");
-        FACEBOOK_SECRET = env.getProperty("facebook_secret");
+    public FacebookLogin() {
         serviceBuilder = new ServiceBuilder();
     }