Recommendation subscribers should not contain message author

1 files changed, 11 insertions, 8 deletions

diff --git a/juick-server/src/test/java/com/juick/server/tests/ServerTests.java b/juick-server/src/test/java/com/juick/server/tests/ServerTests.java
index 646e1443..297a3c88 100644
--- a/juick-server/src/test/java/com/juick/server/tests/ServerTests.java
+++ b/juick-server/src/test/java/com/juick/server/tests/ServerTests.java
@@ -1183,21 +1183,24 @@ public class ServerTests {
         Tag sampleTag = tagService.getTag("banned", true);
         int posterMid = messagesService.createMessage(posterId, "YO", null, Collections.singletonList(sampleTag));
         messagesService.recommendMessage(posterMid, recommenderId);
-        BiFunction<Integer, Integer, List<User>> subscribers = (recommId, msgId) ->
-                subscriptionService.getUsersSubscribedToUserRecommendations(recommId, msgId, posterId);
-        List<User> recommendSubscribers = subscribers.apply(recommenderId, posterMid);
+        BiFunction<Integer, Message, List<User>> subscribers = (recommId, msg) ->
+                subscriptionService.getUsersSubscribedToUserRecommendations(recommId, msg);
+        List<User> recommendSubscribers = subscribers.apply(recommenderId, messagesService.getMessage(posterMid));
         assertThat(recommendSubscribers.size(), is(1));
         assertThat(recommendSubscribers.get(0).getUid(), is(readerId));
         privacyQueriesService.blacklistUser(reader, poster);
-        assertThat(subscribers.apply(recommenderId, posterMid).size(), is(0));
+        assertThat(subscribers.apply(recommenderId, messagesService.getMessage(posterMid)).size(), is(0));
         privacyQueriesService.blacklistUser(reader, poster);
-        assertThat(subscribers.apply(recommenderId, posterMid).size(), is(1));
+        assertThat(subscribers.apply(recommenderId, messagesService.getMessage(posterMid)).size(), is(1));
         tagService.blacklistTag(reader, sampleTag);
-        assertThat(subscribers.apply(recommenderId, posterMid).size(), is(0));
+        assertThat(subscribers.apply(recommenderId, messagesService.getMessage(posterMid)).size(), is(0));
         tagService.blacklistTag(reader, sampleTag);
-        assertThat(subscribers.apply(recommenderId, posterMid).size(), is(1));
+        assertThat(subscribers.apply(recommenderId, messagesService.getMessage(posterMid)).size(), is(1));
         messagesService.recommendMessage(posterMid, lateRecommenderId);
-        List<User> lateRecommendSubscribers = subscribers.apply(recommenderId, posterMid);
+        List<User> lateRecommendSubscribers = subscribers.apply(recommenderId, messagesService.getMessage(posterMid));
         assertThat(lateRecommendSubscribers.size(), is(0));
+        int readerMid = messagesService.createMessage(readerId, "PEOPLE", null, null);
+        messagesService.recommendMessage(readerMid, recommenderId);
+        assertThat(subscribers.apply(recommenderId, messagesService.getMessage(readerMid)).size(), is(0));
     }
 }